[systemd-devel] [PATCH] bootchart: use conf-parser & CamelCase names in .conf
Thomas H.P. Andersen
phomes at gmail.com
Wed Feb 13 14:54:26 PST 2013
On Wed, Feb 13, 2013 at 10:31 PM, Lennart Poettering
<lennart at poettering.net> wrote:
> On Wed, 13.02.13 12:20, Kok, Auke-jan H (auke-jan.h.kok at intel.com) wrote:
>> On Wed, Feb 13, 2013 at 11:31 AM, Lennart Poettering
>> <lennart at poettering.net> wrote:
>> > On Wed, 13.02.13 20:24, Thomas Hindoe Paaboel Andersen (phomes at gmail.com) wrote:
>> >> +[Bootchart]
>> >> +#Samples=500
>> >> +#Freq=25
>> >> +#Rel=0
>> >> +#Filter=1
>> >> +#Output=<folder name, defaults to /var/log>
>> This has changed to /run/log being the default with Harald's patch I
>> merged yesterday.
>> >> +#Init=/path/to/init-binary
>> >> +#Pss=0
>> > Hmm, so in systemd so far we tried to avoid abbreviations like this in
>> > exported identifiers. So I'd really prefer if we could use "Frequency"
>> > instead of "Freq" here. Abbreviations and acronyms raise the bar for
>> > newcomers.
>> agreed, as part of this conversion we should just rename these options
>> to Frequency, Relative.
>> > It's not to say we'd never export abbreviations/acronyms anywhere in
>> > systemd, but if we do, then they must be very very well established...
>> Pss, is still an acronym, but Let's keep it that way.
> Hmm, what does this stand for? Wikipedia doesn't have it, can't be that
> well known...
> Also, if it's an acronym it should probably be PSS not Pss...
Sent an updated patch with the suggested changes but still Pss.
Maybe PSSGraph and EntropyGraph? Btw. we read those two and
Filter/Relative as ints, but they are used as bools. Maybe it would be
clearer if we parse them as such so we can write .e.g. "Relative=no"
in the conf file?
More information about the systemd-devel