[systemd-devel] [PATCH] bootchart: if "root=/dev" is not matched, don't try to read /sys

[Kok, Auke-jan H]

On Thu, Feb 14, 2013 at 5:20 AM, Tom Gundersen <teg at jklm.no> wrote:
> On Thu, Feb 14, 2013 at 11:26 AM,  <harald at redhat.com> wrote:
>> From: Harald Hoyer <harald at redhat.com>
>>
>> ---
>>  src/bootchart/svg.c | 17 +++++++++--------
>>  1 file changed, 9 insertions(+), 8 deletions(-)
>>
>> diff --git a/src/bootchart/svg.c b/src/bootchart/svg.c
>> index dc55cb3..7fdcd01 100644
>> --- a/src/bootchart/svg.c
>> +++ b/src/bootchart/svg.c
>> @@ -166,18 +166,19 @@ static void svg_title(void)
>>          }
>>
>>          /* extract root fs so we can find disk model name in sysfs */
>> +        /* FIXME: this works only in the simple case */
>
> Couldn't we simply query the '-.mount' unit to find out 'What=' and
> then use libudev to get the model name?

Right, but, that would pull in dbus, libudev. For now, this patch is
fine - we'll get to using dbus once we're ready to add service display
and grouping...

Merged this patch, thanks.

Auke