[systemd-devel] [v2] udev: Expose new ISO9660 props from libblkid

Kay Sievers kay at vrfy.org
Sat Feb 16 16:38:48 PST 2013


On Sat, Feb 16, 2013 at 10:53 PM, Zeeshan Ali (Khattak)
<zeeshanak at gnome.org> wrote:
> On Sat, Feb 16, 2013 at 8:04 PM, Kay Sievers <kay at vrfy.org> wrote:
>> We just hex encode stuff that isn't ascii or valid utf8, udev just
>> mangles some old values for compat reasons, new stuff should only use
>> encoding.
>
> You mean these new values I'm adding will only pass through
> blkid_encode_string and not blkid_safe_string?

Yes.

> Cause  docs for
> blkid_safe_string() say: "Replaces all whitespaces with '_'."

Do not use it.

> If so
> IMHO it'd be also nice for apps to be able to get the volume ID with
> whitespace intact (not talking of leading/trailing WS that blkid
> removes for you already and doubtful to be useful to anyone). Pretty
> sure you have good reasons to not change the format of existing
> 'ID_FS_LABEL' property but maybe raw label could be exposed as a
> separate property for anyone interested?

The old values are also exported as *_ENC. Just ignore all that,
encode the string and export it as a normal name.

Kay


More information about the systemd-devel mailing list