[systemd-devel] [PATCH 3/6] nss-myhostname: integrate into systemd buildsystem

[Tom Gundersen]

Sorry, I accidentally dropped the ML.

On Sun, Jan 6, 2013 at 2:01 AM, Zbigniew Jędrzejewski-Szmek
<zbyszek at in.waw.pl> wrote:
> On Sat, Jan 05, 2013 at 10:58:01PM +0100, Tom Gundersen wrote:
>> On Sat, Jan 5, 2013 at 10:30 PM, Zbigniew Jędrzejewski-Szmek
>> <zbyszek at in.waw.pl> wrote:
>> >> +myhostname-install-exec-hook:
>> >> +     rm -f $(DESTDIR)$(libdir)/libnss_myhostname.la
>> >> +     rm -f $(DESTDIR)$(libdir)/libnss_myhostname_minimal.la
>> >> +
>> >> +myhostname-uninstall-hook:
>> >> +     rm -f $(DESTDIR)$(libdir)/libnss_myhostname.so.2
>> >> +     rm -f $(DESTDIR)$(libdir)/libnss_myhostname_minimal.so.2
>> >> +
>> >> +INSTALL_EXEC_HOOKS += \
>> >> +     myhostname-install-exec-hook
>> >> +
>> >> +UNINSTALL_EXEC_HOOKS += \
>> >> +     myhostname-uninstall-hook
>> >> +endif
>> > Are those hooks necessary? Other libs have hooks only if they are
>> > moved to rootlibdir during installation.
>>
>> Good point. The uninstall hook is indeed not necessary, I will remove
>> it. The install hook is necessary, or the .la file will be installed.
>
> Don't the other .la files get installed? Should libnss_myhostname be
> different?

This was what the old nss-myhostname did. Lennart: any good reason to
exclude the .la or should nss-myhostname be treated the same as the
other libs?

-t