[systemd-devel] [PATCH] [RFC] systemd-bootchart: merge bootchart.

[Kok, Auke-jan H]

On Sun, Jan 6, 2013 at 6:54 PM, Zbigniew Jędrzejewski-Szmek
<zbyszek at in.waw.pl> wrote:
> On Sun, Jan 06, 2013 at 06:35:18PM -0800, Kok, Auke-jan H wrote:
>> On Sun, Jan 6, 2013 at 11:35 AM, Lennart Poettering
>> <lennart at poettering.net> wrote:
>> > On Sun, 06.01.13 20:11, Zbigniew Jędrzejewski-Szmek (zbyszek at in.waw.pl) wrote:
>> >
>> >>
>> >> On Wed, Oct 17, 2012 at 04:01:12PM -0700, Auke Kok wrote:
>> >> > << do not merge this patch - it has not been fully tested yet >>
>> >> >
>> >> > This is an initial RFC patch merging bootchart almost verbatim
>> >> > into systemd.
>> >> >
>> >> > Bootchart is renamed to 'systemd-bootchart' and installed as
>> >> > $libdir/systemd/systemd-bootchart. The configuration file
>> >> > will reside in $sysconfdir/systemd/bootchart.conf.
>> >> >
>> >> > The code is almost unchanged. Graphing routines and logging code
>> >> > do not use or leverage any additional systemd data that may be
>> >> > available. This work is planned after the initial merge.
>> >> Hi,
>> >> any updates?
>> >
>> > We should totally merge this now. We can clean up the few thigns that
>> > need cleaning up after the commit, after all this is fairly
>> > self-contained...
>> >
>> > If you were wondering whether to merge it, go ahead! ;-)
>>
>> That would be just great. I have a ton of little things planned to do
>> but travel and vacation cut into my coding time heavily for the last 2
>> months.
>>
>> The RFC patch is a pretty good start - I don't see a reason to merge
>> that one and go from there - I don't have anything else staged right
>> now, and with the attention I've already gotten, I think we'll go a
>> lot quicker if we just merge it as is.
> Agreed. Nevertheless, are you sure that you want to merge it
> "flattened", without previous history? It seems to me that bootchart
> commit messages are not particularly consistent, but they still would
> be useful to understand the history of the code... Other projects
> (udev, nss-myhostname) were/will be merged with history.

That and I'm not going to de-publish the standalone version for a bit
as a few distros are still using it.

I'm fine with it being merged without history. It's not that big.


Auke