[systemd-devel] bootchart: tabs to spaces?

Kok, Auke-jan H auke-jan.h.kok at intel.com
Thu Jan 10 11:48:56 PST 2013


On Thu, Jan 10, 2013 at 11:41 AM, Thomas H.P. Andersen <phomes at gmail.com> wrote:
> On Thu, Jan 10, 2013 at 7:24 PM, Kok, Auke-jan H
> <auke-jan.h.kok at intel.com> wrote:
>> On Thu, Jan 10, 2013 at 3:35 AM, Kay Sievers <kay at vrfy.org> wrote:
>>> On Thu, Jan 10, 2013 at 6:49 AM, Alessandro Delgado
>>> <adelgado1313 at gmail.com> wrote:
>>>> I like tabs better.
>>>>
>>>> Though the question should answer itself looking at the involving
>>>> environment codebase. Consistency is what matters.
>>>
>>> Tabs would make sense if we would use them strictly for indentation
>>> and never for any kind of alignment. Then people could switch to any
>>> number of tab width, and all would still look fine. That actually
>>> would be a nice feature in theory.
>>>
>>> But that's really not what people, or the "kernel-style" do with tabs,
>>> they mix everything, it works only with 8 spaces tabs, or stuff gets
>>> garbled when displayed. Hence tabs are a broken idea, have zero
>>> benefit, they just needlessly complicate things and look ugly. We
>>> don't want them anymore. :)
>>
>> I'll do a patch myself to convert it - I'll submit it later today.
>
> I already committed the patch to switch to spaces yesterday. I
> understood your "well then, better do it quickly" as an okay for the
> patch.

No worries, it's not much more than a `sed` anyway.

Auke


More information about the systemd-devel mailing list