[systemd-devel] [PATCH] do not ellipsize cgroup members in full status

[Zbigniew Jędrzejewski-Szmek]

On Tue, Jan 15, 2013 at 10:58:26AM +0100, Lukáš Nykrýn wrote:
> Subject: [PATCH] systemctl,loginctl,cgls: do not ellipsize cgroup members
>  when --full is specified
> 
> diff --git a/man/systemctl.xml b/man/systemctl.xml
> index 2f33e0c..0289200 100644
> --- a/man/systemctl.xml
> +++ b/man/systemctl.xml
> @@ -156,7 +156,7 @@
>                                  <term><option>--full</option></term>
>  
>                                  <listitem><para>Do not ellipsize unit
> -                                names and truncate unit descriptions
> +                                names, cgroup members and truncate unit descriptions
                                                        ^comma here
>                                  in the output of
>                                  <command>list-units</command> and
>                                  <command>list-jobs</command>.</para></listitem>
Hi Lukas,
I don't think it's working as advertised:

$  systemd/build/systemctl status -f network.service
     Loaded: loaded (/etc/rc.d/init.d/network)
       Active: active (running) since Mon 2013-01-14 04:00:35 CET; 1 day 13h ago
        Process: 476 ExecStart=/etc/rc.d/init.d/network start (code=exited, status=0/SUCCESS)
	  CGroup: name=systemd:/system/network.service
	  	    \661 /sbin/dhclient -H fedora-15 -1 -q -cf /etc/dh...

I'd expect this last line to be shown in full.

Also, unit names seem to always be ellipsized:

$ systemd/build/systemctl -f
UNIT                      LOAD   ACTIVE SUB       DESCRIPTION
proc-sys...misc.automount loaded active waiting   Arbitrary Executable F

AFAICT, your patch didn't change this behaviour, but it
would be nice to bring the documentation and behaviour in
line.

> diff --git a/man/systemd-cgls.xml b/man/systemd-cgls.xml
> index 4b6ee93..b280b87 100644
> --- a/man/systemd-cgls.xml
> +++ b/man/systemd-cgls.xml
> @@ -111,6 +111,14 @@
>                          </varlistentry>
>  
>                          <varlistentry>
> +                                <term><option>--full</option></term>
> +
> +                                <listitem><para>Do not ellipsize cgroup
> +                                members.</para>
> +                                </listitem>
> +                        </varlistentry>
> +
> +                        <varlistentry>
>                                  <term><option>-k</option></term>
This works, but is off by default. If we are under a pager, it makes
little sense to ellipsize long lines, so the default could be reversed.

Zbyszek