[systemd-devel] systemd-analyze-197 broken

[Kok, Auke-jan H]

On Tue, Jan 15, 2013 at 9:46 AM, Peeters Simon <peeters.simon at gmail.com> wrote:
> 2013/1/15 Peeters Simon <peeters.simon at gmail.com>:
>> 2013/1/15 Colin Guthrie <gmane at colin.guthr.ie>:
>>> 'Twas brillig, and Kok, Auke-jan H at 14/01/13 23:55 did gyre and gimble:
>>>>> > does systemd really need to introduce one 3rd party component
>>>>> > after the next (libmicrohttpd as example) which will sooner
>>>>> > or later terrible break due incompatible changes in this minefiled
>>>> I don't think it's as bad as you portray it, but I have an intern
>>>> software engineer that I will be making systemd-analyze (the non-plot
>>>> parts - the plot parts should be replaced by bootchart IMO) rewrite in
>>>> C, so hopefully we can put some of this behind us soon enough.
>>
>> I had a couple of hours time today and couldn't resist hacking a bit on .
>> It is a quiet literal translation of the python script with some
>> infrastructure copy-pasted from other places in systemd, and it still
>> misses most error checking, but it works :)
>>
>> Værsågod, Alsjeblieft, Voici, Bitte and Here you are:
>> https://gist.github.com/4539003
>>
>>> I find the systemd-analyze plots pretty useful generally. It would be a
>>> shame to drop it in favour of bootchart if bootchart still requires a
>>> separate init to be run. i.e. "I've got a problem on this boot right
>>> now, I'd like a quick graphical representation of it please!" type use
>>> cases.
>>>
>>> I agree in principle with the other posts: i.e. less python deps if
>>> possible (it's just writing an svg? It's just XML why does it need a
>>> whole python backend??) and more useful information about timeouts and
>>> failed jobs etc. etc.
>>
>> it in deed would be just writing the xml (like bootchart does), but
>> the current implementation uses cairo to do this, and those svg files
>> are horrible. If i have some time left i can look into this (this is
>> actually just mixing the drawing part of bootchart with the code i
>> already have for "blame")
>
> done!
>
> the code is ugly, but it works :)
>
> url is still https://gist.github.com/4539003
> i added an example plot from my system:
> https://gist.github.com/raw/4539003/6115831235f9a0fa8db8eaf88147d527437045a2/plot.svg
>
> If somebody feels the need to start cleaning it up, feel free to do so.

Nice, I'll certainly try and make some time to review/test this! thanks Simon!

Auke