[systemd-devel] [PATCH] continuation support in envinronment files

[Lennart Poettering]

On Fri, 11.01.13 15:03, Michal Vyskocil (mvyskocil at suse.cz) wrote:

Minor nitpick:

> +                if (endswith(p, "\\")) {
> +                        *(p+strlen(p)-1) = '\0';
> +
> +                        if (!(c = strappend(b, p))) {

For new code we prefer

         ...
         c = strappend(b, p);
         if (!c) {
         ...

Rather then the on-line syntax.

Looks good otherwise (modulo the issues Zbigniew's raised).

Lennart

-- 
Lennart Poettering - Red Hat, Inc.