[systemd-devel] [PATCH] do not ellipsize cgroup members in full status

[Zbigniew Jędrzejewski-Szmek]

On Wed, Jan 16, 2013 at 04:59:47PM +0100, Lukáš Nykrýn wrote:
> Subject: [PATCH] systemctl,loginctl,cgls: do not ellipsize cgroup members
>  when --full is specified
> 
> New file output.h with output flags and modes.
> 
> --full parameter also for cgls and loginctl.
> 
> Include 'all' parameter in flags (show_cgroup_by_path, show_cgroup,
> show_cgroup_and_extra, show_cgroup_and_extra_by_spec).
> 
> get_process_cmdline with max_length == 0 will not ellipsize output.
> 
> Replace LINE_MAX with 0 in some calls of get_process_cmdline.
Hi,
I commited your patch with some small changes. Most importantly, I
dropped '-f'. You actually forgot to add 'f' to the getopt invocation,
so it didn't work. I took that to mean that the option is not quite
necessary :) Seriously speaking, I also changed cgls to default to
--full, so the short option is likely not necessary. If we add a short
option for --full, I think that we should find a different letter ('U'
seems to be the only one free), which can be shared between different
systemd commands. I don't want '-f' to mean '--full' sometimes, and
'--force' othertimes, leading to unexpected results.

Zbyszek