[systemd-devel] systemd-analyze-197 broken

[Kok, Auke-jan H]

On Sat, Jan 19, 2013 at 7:48 AM, Peeters Simon <peeters.simon at gmail.com> wrote:
> 2013/1/17 Kok, Auke-jan H <auke-jan.h.kok at intel.com>:
>> For those that wish to test this, here is a patch against HEAD that
>> integrates it and replaces the current script
>>
>>     http://foo-projects.org/~sofar/0001-systemd-analyze-rewrite-in-C.patch
>
> thank you for making it into a nice patch :)
>
>> This should give people some time to test it.
>>
>> I spotted a few problems but nothing unfixable/problematic - e.g. on
>> my system it throws DBus errors when trying to get the EFI boot
>> parameters.
>
> What kind of errors are you getting? On my system i get nice '0'
> values (non efi system).
> So perhaps the problem is with systemd sending the value?
>
> What do you get when trying:
> dbus-send --system --dest=org.freedesktop.systemd1 --type=method_call
> --print-reply /org/freedesktop/systemd1
> org.freedesktop.DBus.Properties.Get
> string:org.freedesktop.systemd1.Manager
> string:FirmwareTimestampMonotonic
>
> i get "   variant       uint64 0" on that one.
>
> ps: doing some extra cleaning on the code, expect a new patch soon.

I just updated my EFI system to HEAD with your latest patch applied,
and everything works fine - the DBus warnings are now gone.

However, I'm not seeing any EFI times in the resulting plots, I'm not
sure what is going on but gummiboot is used on this system (maybe I
need to update that).


$ dbus-send --system --dest=org.freedesktop.systemd1
--type=method_call --print-reply /org/freedesktop/systemd1
org.freedesktop.DBus.Properties.Get
string:org.freedesktop.systemd1.Manager
string:FirmwareTimestampMonotonic
method return sender=:1.3 -> dest=:1.21 reply_serial=2
   variant       uint64 0

I do see the EFI vars that gummiboot sets:

/sys/firmware/efi/vars/LoaderTicksInit-4a67b082-0a4c-41cf-b6c7-440b29bb8c4f/

not sure what is going on here...

I'm getting these warnings:

Making all in .
  CC       src/analyze/systemd_analyze-systemd-analyze.o
src/analyze/systemd-analyze.c:50:24: warning: no previous prototype
for 'property_getull' [-Wmissing-prototypes]
src/analyze/systemd-analyze.c:141:5: warning: no previous prototype
for 'acquire_time_data' [-Wmissing-prototypes]
src/analyze/systemd-analyze.c:272:6: warning: no previous prototype
for 'get_global_timing' [-Wmissing-prototypes]
src/analyze/systemd-analyze.c:310:5: warning: no previous prototype
for 'analyze_plot' [-Wmissing-prototypes]
src/analyze/systemd-analyze.c:435:5: warning: no previous prototype
for 'analyze_blame' [-Wmissing-prototypes]
src/analyze/systemd-analyze.c:451:5: warning: no previous prototype
for 'analyze_time' [-Wmissing-prototypes]
src/analyze/systemd-analyze.c:476:6: warning: no previous prototype
for 'analyze_help' [-Wmissing-prototypes]

you just want to make all those static.

Auke