[systemd-devel] [PATCH] core: Set source for mountinfo .mount units

Umut Tezduyar umut at tezduyar.com
Wed Jan 23 00:28:23 PST 2013


Regardless of this patch, it might be a good idea to mention
/proc/self/mountinfo in systemd.mount(5) as currently there is no mention
of .mount files might pop up by systemd by looking at /proc/self/mountinfo.
Thanks


On Wed, Jan 23, 2013 at 9:23 AM, Umut Tezduyar <umut at tezduyar.com> wrote:

> ---
>  src/core/mount.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/src/core/mount.c b/src/core/mount.c
> index 03eff9d..e5f5e42 100644
> --- a/src/core/mount.c
> +++ b/src/core/mount.c
> @@ -1472,7 +1472,7 @@ static int mount_add_one(
>          int r;
>          Unit *u;
>          bool delete;
> -        char *e, *w = NULL, *o = NULL, *f = NULL;
> +        char *e, *w = NULL, *o = NULL, *s = NULL, *f = NULL;
>          MountParameters *p;
>          bool load_extras = false;
>
> @@ -1545,6 +1545,7 @@ static int mount_add_one(
>
>          if (!(w = strdup(what)) ||
>              !(o = strdup(options)) ||
> +            !(s = strdup("/proc/self/mountinfo")) ||
>              !(f = strdup(fstype))) {
>                  r = -ENOMEM;
>                  goto fail;
> @@ -1558,6 +1559,8 @@ static int mount_add_one(
>          }
>
>          MOUNT(u)->from_proc_self_mountinfo = true;
> +        free(u->source_path);
> +        u->source_path = s;
>
>          free(p->what);
>          p->what = w;
> @@ -1583,6 +1586,7 @@ static int mount_add_one(
>  fail:
>          free(w);
>          free(o);
> +        free(s);
>          free(f);
>
>          if (delete && u)
> --
> 1.7.2.5
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20130123/7ac00c4a/attachment.html>


More information about the systemd-devel mailing list