[systemd-devel] [PATCH 2/2] service: make sure the watchdog timer is not restarted while stopping

Zbigniew Jędrzejewski-Szmek zbyszek at in.waw.pl
Thu Jan 24 16:51:26 PST 2013


On Wed, Jan 23, 2013 at 02:12:16PM +0100, Michael Olbrich wrote:
> For services without ExecStop= the state SERVICE_STOP is never
> entered. as a result the watchdog timer is not stopped and the service
> is restarted (if it is configuered to restart).  Stopping the watchdog
> timer for SERVICE_STOP_SIGTERM as well fixes this.

> A watchdog notification may be handled after the watchdog timer was stopped
> while stopping the service. As a result the timer is restarted and the
> service may be restarted as well.
> The watchdog timestamp is initially set during startup in
> service_enter_start_post() and cleared when the timer is stopped. Therefore
> it can be used as an indication if the timer should be reset.

Applied both.

Zbyszek


More information about the systemd-devel mailing list