[systemd-devel] [PATCH 2/2] journal, readahead: remove file handle leaks

[David Strauss]

Does the leak show up under Valgrind with fd checking enabled?

On Sun, Jan 27, 2013 at 1:58 PM, Kay Sievers <kay at vrfy.org> wrote:
> On Sun, Jan 27, 2013 at 10:51 PM, Sami Kerola <kerolasa at iki.fi> wrote:
>> Found with the coccicheck-0.2.4 open file check.
>
> I didn't check the whole list, but where I looked, the check is just
> not smart enough to understand:
>   _cleanup_fclose_ FILE *f = NULL;
>
> which causes the cleanup automatically to be added by the compiler and
> not by explicit code. It's used that way in many places in the systemd
> code.
>
> Kay
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel



-- 
David Strauss
   | david at davidstrauss.net
   | +1 512 577 5827 [mobile]