[systemd-devel] [PATCH] systemctl: Fix wrong assertion test

Dave Reisner d at falconindy.com
Wed Jan 30 11:06:35 PST 2013


On Wed, Jan 30, 2013 at 04:55:24PM -0200, Mauro Dreissig wrote:
> ---
>  src/systemctl/systemctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c
> index 408a4f0..5deacbf 100644
> --- a/src/systemctl/systemctl.c
> +++ b/src/systemctl/systemctl.c
> @@ -1013,7 +1013,7 @@ static int dot_one(DBusConnection *bus, const char *name, const char *path) {
>          while (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_INVALID) {
>                  const char *prop;
>  
> -                assert(dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_DICT_ENTRY);
> +                assert(dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_DICT_ENTRY);

This was already fixed in ec76596cab6298ae1fb9d7cbe4ad56f175e87943.

>                  dbus_message_iter_recurse(&sub, &sub2);
>  
>                  if (bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &prop, true) < 0 ||
> -- 
> 1.7.11.7
> 
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel


More information about the systemd-devel mailing list