[systemd-devel] [PATCH 3/3 (rebased)] cryptsetup: Add tcrypt support

Lennart Poettering lennart at poettering.net
Fri Jul 12 11:36:26 PDT 2013


On Tue, 09.07.13 21:15, Jan Janssen (medhefgo at web.de) wrote:

> +        if (*key_file) {
> +                r = read_one_line_file(*key_file, &passphrase);
> +                if (r < 0) {
> +                        log_error("Failed to read key file: %s", strerror(-r));
> +                        *key_file = NULL;
> +                        return -EAGAIN;

I can't say I like functions that change the parameters when they fail,
any chance we can fix that?

otherwise looks good.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.


More information about the systemd-devel mailing list