[systemd-devel] [RFC PATCH] condition: add ConditionFileContains=

Karol Lewandowski lmctlx at gmail.com
Sat Jul 13 15:36:23 PDT 2013


On Fri, Jul 12, 2013 at 09:19:58PM +0200, Lennart Poettering wrote:
> On Fri, 12.07.13 20:42, Karol Lewandowski (k.lewandowsk at samsung.com) wrote:
...
> >  - software raid (md) status - /proc/mdstat
> 
> Not sure what this is really doing...

/etc/init.d/hdparm seems to be bailing out if md-raid is not
fully operational and /etc/init.d/halt doesn't pass "-h" to
final halt(8) if md is in active state.

> > Every such case could be handled by generic "built-in grep"
> > instead of dozen of flags like ConditionCPUFeature=,
> > ConditionMDStatus=, ...
> 
> I am pretty sure we cover most of these cases with some other way too.
> 
> I mean, I am generally willing to add this, but if there's no strict
> need for it, I'd avoid it.

Let's avoid it for now as our use case can be solved by udev rule
(as Kay suggested).  I'll take closer into Tizen boot sequence next
monday to see if there are other cases where feature like this might
come useful (hopefully I won't find any).

Thanks


More information about the systemd-devel mailing list