[systemd-devel] [PATCHv3 2/2] logind: apply ACL's to "dead" device nodes

[Lennart Poettering]

On Tue, 16.07.13 20:39, Lennart Poettering (lennart at poettering.net) wrote:

> > +                                goto finish;
> > +                        }
> > +
> > +                        n = strappend("/dev/", unescaped_devname);
> 
> Good candidate for strappenda?

I take this back. Awful candidate for strappenda() since this is inside
a loop, and you cannot sanely use alloca() in a loop, since it keeps
appending to the stack.

So, please keep using strappend() for this one.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.