[systemd-devel] [PATCH] [RFC] systemctl-clock: Use monotonic instead of realtime clock

Lennart Poettering lennart at poettering.net
Tue Jul 16 17:41:01 PDT 2013


On Tue, 25.06.13 18:58, Shakeel, Muhammad (muhammad_shakeel at mentor.com) wrote:

> From: Muhammad Shakeel <mshakeel at pkl-mshakeel-ubuntu.(none)>
> 
> Currently if system clock is updated then 'ago' part of any service
> running time doesn't show correct information. This is reported here:
> https://bugs.freedesktop.org/show_bug.cgi?id=65616

Looks good in principle, but I am not really happy about changing the
clock format_timestamp_relative() works on without indicating that in
any way in the name of that function. 

Maybe rename format_timestamp() to format_timestamp_realtime() and
format_timestamp_relative() to format_timestamp_monotonic()? I think
that would be a lot more descriptive?

Lennart

-- 
Lennart Poettering - Red Hat, Inc.


More information about the systemd-devel mailing list