[systemd-devel] [PATCH v5] journalctl: Add support for showing messages from a previous boot

[Zbigniew Jędrzejewski-Szmek]

On Tue, Jul 16, 2013 at 05:46:04PM +0200, Lennart Poettering wrote:
> On Tue, 16.07.13 17:42, Zbigniew Jędrzejewski-Szmek (zbyszek at in.waw.pl) wrote:
> 
> > 
> > On Tue, Jul 16, 2013 at 05:39:54PM +0200, Lennart Poettering wrote:
> > > On Fri, 28.06.13 17:26, Jan Janssen (medhefgo at web.de) wrote:
> > > Applied this one now. If people start complaining about its speed we can
> > > reinvestigate and do find some way for optimization...
> > We need to think about negative matches. Looking for previous boots
> > with negative matches should work nicely.
> 
> The bisection tables make this less efficient but certainly possible.
> 
> > I'd like to complain about the : in the syntax though.
> 
> Hmm, what would you propose? There's still time to fix it!
I went ahead, and removed : from the syntax. It feels OK in my testing.

And I also made one optimization, which is important imho: 'journactl -b'
will still use the boot id from sd_id128_get_boot() to avoid searching
through the tables, and 'journalctl -b BOOT_ID[+-0]' will just
use  BOOT_ID without searching through the tables. This should help
a lot when running with cold cache.

Zbyszek

-- 
they are not broken. they are refucktored
                           -- alxchk