[systemd-devel] [PATCH] makefile:put macros file to the correct place

[Vaclav Pavlin]

----- Original Message -----
From: "Kay Sievers" <kay at redhat.com>
To: "Václav Pavlín" <vpavlin at redhat.com>
Cc: "Zbigniew Jędrzejewski-Szmek" <zbyszek at in.waw.pl>, "Fedora systemd team" <systemd-maint at redhat.com>, systemd-devel at lists.freedesktop.org
Sent: Friday, June 28, 2013 11:25:49 AM
Subject: Re: [systemd-devel] [PATCH] makefile:put macros file to the correct	place



----- Original Message -----
> Zbigniew Jędrzejewski-Szmek píše v Čt 27. 06. 2013 v 17:00 +0200:
> > On Thu, Jun 27, 2013 at 04:30:12PM +0200, Vaclav Pavlin wrote:
> > > From: Fedora systemd team <systemd-maint at redhat.com>
> > > 
> > > ---
> > >  Makefile.am | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/Makefile.am b/Makefile.am
> > > index 3a196a6..c3988e8 100644
> > > --- a/Makefile.am
> > > +++ b/Makefile.am
> > > @@ -65,7 +65,7 @@ pkgconfigdatadir=$(datadir)/pkgconfig
> > >  pkgconfiglibdir=$(libdir)/pkgconfig
> > >  polkitpolicydir=$(datadir)/polkit-1/actions
> > >  bashcompletiondir=@bashcompletiondir@
> > > -rpmmacrosdir=$(sysconfdir)/rpm
> > > +rpmmacrosdir=$(prefix)/lib/rpm/macros.d
> > Is this a recent change in rpmbuild? I don't see any macros
> > in the new dir on FC19, and even don't have the dir on FC18...
> > 
> > Zbyszek
> RPM guys removed systemd from default build-requires in buildroot by
> mistake. So we discussed how to do it so that systemd does not have to
> be default require for all packages that ship unit files. The result of
> this discussion was that we create a subpackage that will contain only
> rpm macro files.

We used to have systemd-units for that, and it did not really
work out to be useful and we merged it back. Why would it work
today?

It seems to be a pretty pattern to have a <pkg>-filesystem.rpm
for larger projects. A package that contains the skeleton of empty
directories.

Should the empty directories also go into that package?

Does the pkgconfig file needs to be packaged along with rpm macro file?

> Michal Schmidt then suggested we could follow this bugzilla
> https://bugzilla.redhat.com/show_bug.cgi?id=846679 and move macro file
> to the new location. And yes, this applies only for F19+.

Nice. Maybe some day we will really have a clean /etc, with packages
not messing around in it. :)

Kay


I am not sure about the directories, but I think it would do no harm if we move them to the subpackage.