[systemd-devel] [PATCH] make: Automake is complaining about .PRECIOUS being redefined

[Zbigniew Jędrzejewski-Szmek]

On Thu, Jul 18, 2013 at 09:18:55AM +0200, Holger Hans Peter Freyther wrote:
> From: Holger Hans Peter Freyther <holger at moiji-mobile.com>
> 
> Yesterday I added test-suite.log as dependency to the .PRECIOUS
> target. Automake is warning about this target being redefined
> and from what I see there is no way I can stop the warning but
> I can add the %MAKEFILE% as dependency.
> 
> automake warning:
> Makefile.am:35: warning: user target '.PRECIOUS' defined here ...
> /usr/share/automake-1.13/am/configure.am: ... overrides Automake target '.PRECIOUS' defined here
Applied for now.

But that looks like a plain automake bug. It should know that targets
starting with a dot are not real targets. Could you file a bug
report with automake, so this gets fixed properly?

Zbyszek

> ---
>  Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index e598585..c9b0715 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -32,7 +32,7 @@ SUBDIRS = . po
>  .SECONDARY:
>  
>  # Keep the test-suite.log
> -.PRECIOUS: $(TEST_SUITE_LOG)
> +.PRECIOUS: $(TEST_SUITE_LOG) %MAKEFILE%
>  
>  LIBUDEV_CURRENT=4
>  LIBUDEV_REVISION=6
> -- 
> 1.8.3.2
> 
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel
> 

-- 
they are not broken. they are refucktored
                           -- alxchk