[systemd-devel] [PATCH] make: Automake is complaining about .PRECIOUS being redefined

[Zbigniew Jędrzejewski-Szmek]

On Sat, Jul 20, 2013 at 08:37:14AM +0200, Holger Hans Peter Freyther wrote:
> On Sat, Jul 20, 2013 at 01:09:35AM +0200, Zbigniew Jędrzejewski-Szmek wrote:
> 
> Hi,
> 
> 
> > Applied for now.
> 
> 
> I picked %MAKEFILE% as this is what was in the generated Makefile before
> my patch. I just tried to match the output.
Originally: .PRECIOUS: Makefile
After 1st patch:  .PRECIOUS: $(TEST_SUITE_LOG)
With 2nd patch: .PRECIOUS: $(TEST_SUITE_LOG) %MAKEFILE%
With 2nd patch modified: .PRECIOUS: $(TEST_SUITE_LOG) Makefile

... that's at least how it looks in my testing. I don't think that
having %MAKEFILE% in the final Makefile makes any sense, and it
swhould always be "Makefile". Maybe automake forgets to substitute it
in your case, or something eelse is hapenning.

> 
> > But that looks like a plain automake bug. It should know that targets
> > starting with a dot are not real targets. Could you file a bug
> > report with automake, so this gets fixed properly?
> 
> I sent an email to the automake list and will report back.
Thanks.

Zbyszek

-- 
they are not broken. they are refucktored
                           -- alxchk