[systemd-devel] [PATCH] console-getty.service: conflict with vconsole-setup
zbyszek at in.waw.pl
Sat Jul 20 09:16:36 PDT 2013
On Sat, Jul 20, 2013 at 12:09:09PM +0200, Kay Sievers wrote:
> On Fri, Jul 19, 2013 at 8:31 PM, Zbigniew Jędrzejewski-Szmek
> <zbyszek at in.waw.pl> wrote:
> > On Fri, Jul 19, 2013 at 11:50:53PM +0530, Ramkumar Ramachandra wrote:
> > [intertesting analysis removed]
> >> So, I can provide a patch for getty-generator to detect um Linux and
> >> switch to getty on /dev/console, but vconsole-setup will still fail;
> >> what should we do about that?
> > Make systemd-vconsole-setup.service conditional on
> > ConditionVirtualization=!uml? I don't think any of that setup is needed
> > in that case.
> I think we should rather make vconsole fail gracefully and don't throw
> an error, instead of adding "exotic" options to our primary unit
> What uml does here sound really weird, and vconsole should just
> silently give up when it finds such a messed up setup. :)
Sure, or we can add a one line check in the unit file. That what
we have those Conditions for :) I'm +1 on the patch.
they are not broken. they are refucktored
More information about the systemd-devel