[systemd-devel] [PATCH][usbutils] lsusb: port to hwdb

Greg KH gregkh at linuxfoundation.org
Sun Jul 21 08:34:57 PDT 2013


On Sun, Jul 21, 2013 at 12:01:11PM +0200, Tom Gundersen wrote:
> On Sun, Jul 21, 2013 at 3:34 AM, Greg KH <gregkh at linuxfoundation.org> wrote:
> > Can this mean I can drop the usb.ids file from the usbutils package?  I
> > can't remember where hwdb is generated from, does it rely on the usb.ids
> > file for the initial creation?
> 
> hwdb does not use the usb.ids from the usbutils package.
> 
> However, hwdb only contains vendor, product, class, subclass and
> protocol. So if you drop usb.ids the rest of the information will be
> lost.
> 
> Maybe split the rest out into a separate file and ship only that? Or
> is there a way to get this info into hwdb? Kay?

The "rest" of the info in there should be split out of usb.ids and
probably just imported into the .c code directly, as it's not anything
that changes very often, if at all.  I can move that directly into
usbutils without an issue.

> Also, I just realise there is also lsusb,py, which I did not port.
> What is the usecase for this? Is it also worth porting over?

I agree with Kay, the options it provides should just be moved into the
.c code itself.  I added it years ago when someone sent it to me as it
provided some options that the existing .c code didn't handle.  Other
than color support, I don't think that is true anymore, but I'll look
closer at it to make sure.

thanks,

greg k-h


More information about the systemd-devel mailing list