[systemd-devel] [PATCH] shell-completion: fix zsh completion installation

William Giokas 1007380 at gmail.com
Mon Jul 29 11:51:58 PDT 2013


On Mon, Jul 29, 2013 at 12:23:54PM -0500, William Giokas wrote:
> On Mon, Jul 29, 2013 at 04:07:31PM +0200, Zbigniew Jędrzejewski-Szmek wrote:
> > On Thu, Jul 25, 2013 at 02:00:06PM -0500, William Giokas wrote:
> > > Moved zsh shell completion to shell-completion/zsh/_systemd for
> > > automake's sake. Also allow users to specify where the files should go
> > > with::
> > Makes sense, imho. Should we go one step further and split _systemd
> > like the bash completions were split? This would have at least the
> > advantage that people packaging a subset of systemd could package
> > a subset of completion scripts.
> 
> Sorry, replied off list first.
> 
> Originally this was there just to have the make install put zsh
> completion files in the right place. I would be open to doing this,
> however there are quite a few shared functions between commands, and as
> I have been told, there isn't really a good way to source or store the
> shared functions. I'm still going to try, but I make no promises.

I take back what I just said. All that really stands out is the -H
completion, and that is just a few lines that I don't feel bad about
having in all of the files. Currently I have 13 different files::

    _hostnamectl
    _journalctl
    _localectl
    _loginctl
    _machinectl
    _systemctl
    _systemd
    _systemd-analyze
    _systemd-coredumpctl
    _systemd-inhibit
    _systemd-nspawn
    _timedatectl
    _udevadm

with _systemd being the kind of 'fallback' option, containing the
systemd commands that are less complex, and don't require as much in the
way of functions (most simply use 'flag:desc:(a b c)' or some such).

Thanks,
-- 
William Giokas | KaiSforza | http://kaictl.net/
GnuPG Key: 0x73CD09CF
Fingerprint: F73F 50EF BBE2 9846 8306  E6B8 6902 06D8 73CD 09CF
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20130729/ddc385c4/attachment-0001.pgp>


More information about the systemd-devel mailing list