[systemd-devel] [PATCH] units: cleanup agetty command line

[Karel Zak]

On Mon, Jun 03, 2013 at 06:00:45PM +0100, Colin Guthrie wrote:
> 'Twas brillig, and Karel Zak at 03/06/13 13:28 did gyre and gimble:
> >  * term type is optional (default is 'linux' for virtual terminals
> >    and 'vt102' for serial lines)
> 
> It may no longer matter (especially if the fix mentioned by Michael in
> comment 1 of the bug quoted below is now merged) but FYI the "linux"
> term type was specified explicitly due to agetty not respecting TERM env
> var:

 agetty has been never designed in this way
 
> commit 2161de72c517d34d1ceb9b4c1a300f0b54ce5a9c
> Author: Michal Schmidt <mschmidt at redhat.com>
> Date:   Mon Oct 29 21:59:34 2012 +0100
> 
>     units: agetty overrides TERM
> 
>     Environment=TERM=... has no effect on agetty who sets it by itself. To
>     really set TERM to a specified value, it has to be given on the command
>     line.
> 
>     https://bugzilla.redhat.com/show_bug.cgi?id=870622
> 
> 
> From comment 1:
> "Furthermore, I believe there's a bug in agetty. It attempts to detect
> the distinction between the vc and a serial line and set TERM
> accordingly, but it does not work as expected. I will send Karel a fix."

 ... hmm, I don't remember any discussion.
 
 Add term name to the command line is very poor workaround, distinction
 between the vc and a serial line is critical thing for agetty as it
 modifies many settings on the line.

    Karel

-- 
 Karel Zak  <kzak at redhat.com>
 http://karelzak.blogspot.com