[systemd-devel] [PATCH] udev: make net_id more robust

[Sean McGovern]

Ignore this patch then -- I can't change the PCI geography of my older G4 Mac Mini, and without this patch predictable interface naming does not work for it.

I'll just keep it locally.

-- Sean McGovern
------Original Message------
From: Kay Sievers
To: McGovern, Sean
Cc: systemd-devel at lists.freedesktop.org
Subject: Re: [systemd-devel] [PATCH] udev: make net_id more robust
Sent: Jun 7, 2013 14:25

On Fri, Jun 7, 2013 at 3:27 PM, Sean McGovern <gseanmcg at gmail.com> wrote:
> Onboard network controllers are not always on PCI domain 0.

> +        sysname = udev_device_get_sysname(names->pcidev);
> +
> +        if(!sysname)
> +            return -ENOENT;
> +
> +        if(!strlen(sysname))
> +            return -ENOENT;

None of these checks should be needed.

> +        if(sscanf(sysname, "%lx:%x:%x.%d", &domain, &bus, &slot, &func) != 4)
> +            return -ENOENT;

We only support domain 0, and ignore all other devices so far.

With the above change we would just ignore the domain and allow
possibly conflicting identical names below different domains?

I don't understand what you intend here, please be more specific than
"more robust" in patch descriptions.

Thanks,
Kay