[systemd-devel] [PATCH] udev: Make builtin firmware to find in subdirectories

[Kay Sievers]

On Mon, Jun 17, 2013 at 8:17 AM, WaLyong Cho <fyd0706 at gmail.com> wrote:
> We can specify firmware path using "--with-firmware-path" configure
> option.

This was configurable because some systems had no /lib directory, it
is not meant to carry device or driver specific directories.

> In some of system, firmware can be located in subdirectories of the
> firmware path.

Sure, but the request of the firware would carry the subdirectory. Why
would systems do that otherwise? It does not sound right.

> If there are many firmware directories in below specified path then we
> have to define those to "--with-firmware-path".

I don't understand this. The non-kernel-version subdirectories should
be included in the kernel request, not added by the firmware loader.

> To avoid this, if builtin firmware could not find firmware in specified
> directories then try to find firmware in subdirectories.

This is incompatible with the current in-kernel loader which works
without any userspace helper. Things should really not work the way
the patch introduces. Leading directories should be added to the
kernel firmware request, not searched the firmware loader.

Btw, the entire userspace firmware loading is already disabled by
default in the udev sources, and will be entirely removed in the near
future. Firmware will not be loaded by userspace anymore.

Thanks,
Kay