[systemd-devel] [PATCH] service: don't enter a second SIGTERM/SIGKILL cycle if no ExecStopPost= process is defined

[Michael Olbrich]

On Wed, Jun 12, 2013 at 08:45:35AM +0200, Michael Olbrich wrote:
> It won't help if the main process is still there and there is no new
> process to kill.
> ---
> 
> Hi,
> 
> The second SIGTERM/SIGKILL is to kill ExecStopPost= if necessary, right? In
> that case, this is a better solution.

Can anyone comment on this? The current state is rather annoying.

Michael

>  src/core/service.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/core/service.c b/src/core/service.c
> index dadd981..1319696 100644
> --- a/src/core/service.c
> +++ b/src/core/service.c
> @@ -1968,7 +1968,7 @@ static void service_enter_stop_post(Service *s, ServiceResult f) {
>  
>                  service_set_state(s, SERVICE_STOP_POST);
>          } else
> -                service_enter_signal(s, SERVICE_FINAL_SIGTERM, SERVICE_SUCCESS);
> +                service_enter_dead(s, SERVICE_SUCCESS, true);
>  
>          return;
>  
> -- 
> 1.8.2.rc2
> 
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |