[systemd-devel] Please review the patch about support the samsung series 2 Fn+keys.

Martin Pitt martin.pitt at ubuntu.com
Fri Jun 28 01:18:39 PDT 2013


Hello again,

장동준 [2013-06-28  8:15 +0000]:
> Please review the attached patch for  the samsung series 3 Fn+F* keys(keymap and forced release events).
> This patch is for samsung series3 models.

Ah, I sent my reply to your first patch at the same time when you sent this second patch.

+ENV{DMI_VENDOR}=="[sS][aA][mM][sS][uU][nN][gG]*", ATTR{[dmi/id]product_name}=="*300E5*|*300E4*|*300E7*|*270E5*|*270E4*", RUN+="keyboard-force-release.sh $devpath samsung-series-3"

So you already fixed the "|" and generalized these a bit. I still
wonder if it would be appropriate to use "300*|270*"?

Thanks,

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)


More information about the systemd-devel mailing list