[systemd-devel] [PATCH] fstab-generator: If we wait indefinitely for a mount, wait also for the device

[Harald Hoyer]

On Fri, Mar 1, 2013 at 6:50 PM, Lennart Poettering <lennart at poettering.net
<mailto:lennart at poettering.net>> wrote:

    On Fri, 01.03.13 18:38, Tom Gundersen (teg at jklm.no <mailto:teg at jklm.no>) wrote:

    >
    > On Fri, Mar 1, 2013 at 5:49 PM, Lennart Poettering
    > <lennart at poettering.net <mailto:lennart at poettering.net>> wrote:
    > >> When rootwait is not passed the kernel calls sys_mount() immediately
    > >> (after the equivalent of "udevadm settle") assuming the device will be
    > >> there, failing if it is not. Otherwise, if rootwait is called, the
    > >> kernel will wait (possibly indefinitely) for the device to appear
    > >> before attempting to mount it.
    > >>
    > >> Setting JobTimeout=0 on the device seems correct to me.
    > >
    > > I don't really agree. The difference between the kernel and the initrd
    > > in this regard is that the initrd can offer the user a shell, he can
    > > debug things with. The naked kernel cannot do this. If the root device
    > > doesn't show up we should give the user a shell, so we should timeout
    > > this.
    >
    > Yeah, when using systemd 'rootwait' is not really that useful, as we
    > can do better.

    Harald, do you mind if I revert your patch that added "rootwait" support
    to fstab generator? What's the precise benefit of supporting that in the
    initrd?


Yes, but I didn't add "rootwait"

commit 5e398e546ea65751e6a774daf828fe06f74434a2
Author: Tom Gundersen <teg at jklm.no <mailto:teg at jklm.no>>
Date:   Fri Nov 23 03:41:13 2012 +0100

    fstab-generator: generate new_root.mount in initrd