[systemd-devel] [PATCH 3/5] tpmfiles: add missing parenthesis

Zbigniew Jędrzejewski-Szmek zbyszek at in.waw.pl
Fri Mar 1 13:35:34 PST 2013


On Fri, Mar 01, 2013 at 06:29:59PM +0100, Lukas Nykryn wrote:
> ---
>  src/tmpfiles/tmpfiles.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c
> index 6b3f70e..ba22073 100644
> --- a/src/tmpfiles/tmpfiles.c
> +++ b/src/tmpfiles/tmpfiles.c
> @@ -321,7 +321,7 @@ static int dir_cleanup(
>                          if (age >= cutoff)
>                                  continue;
>  
> -                        if (!i->type == IGNORE_DIRECTORY_PATH || !streq(dent->d_name, p)) {
> +                        if (!(i->type == IGNORE_DIRECTORY_PATH || !streq(dent->d_name, p))) {
After the change we have:
  if (i->type != I_D_P && streq(d_name, p))

Shouldn't we instead have
  if (i->type != I_D_P || strneq(d_name, p))
?

Zbyszek


More information about the systemd-devel mailing list