[systemd-devel] [PATCH 1/5] systemd-python: add missing check for return of PyDict_SetItem in _reader.c

Zbigniew Jędrzejewski-Szmek zbyszek at in.waw.pl
Fri Mar 1 13:45:38 PST 2013


On Fri, Mar 01, 2013 at 06:29:57PM +0100, Lukas Nykryn wrote:
> ---
>  src/python-systemd/_reader.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/python-systemd/_reader.c b/src/python-systemd/_reader.c
> index 7f200d5..d3d45cc 100644
> --- a/src/python-systemd/_reader.c
> +++ b/src/python-systemd/_reader.c
> @@ -208,7 +208,7 @@ static PyObject* Reader_get_next(Reader *self, PyObject *args)
>                  if (r < 0)
>                      goto error;
>  
> -                PyDict_SetItem(dict, key, tmp_list);
> +                r = PyDict_SetItem(dict, key, tmp_list);
>                  if (r < 0)
>                      goto error;
>              }
Applied. Thanks!

Zbyszek


More information about the systemd-devel mailing list