[systemd-devel] [PATCH] bootchart: add parameter "-C" to expand process names to the full cmdline

[Kok, Auke-jan H]

On Wed, Mar 6, 2013 at 9:48 AM, Harald Hoyer <harald.hoyer at gmail.com> wrote:
> On Wed, Mar 6, 2013 at 6:32 PM, Zbigniew Jędrzejewski-Szmek
> <zbyszek at in.waw.pl> wrote:
>> Shouldn't those two identical blocks of code be a function?
>
> true
>
>> Also, why not use _cleanup_close_ for the fd?
>
> Oh :) bootchart could use a lot of cleanup :)

sadly, indeed ;^)

>> From the other mail:
>> """
>> this is needed, because we can't have "--" inside <!-- comment -->
>> """
>> Why not put it here in a comment?
>
> Forgot to add the comment, that's why I sent the email, before sending
> out the whole patch again.

do you want to resend?

Auke