[systemd-devel] [PATCH] core: fix getting information about mount unit

[Umut Tezduyar]

Hi,

I thought mounts coming from mountinfo are not getting default dependencies
anyways. mount_add_one() never sets "load_extras" to true for new mount
units. "load_extras" is the control to call mount_add_extras which will
eventually call mount_add_default_dependencies(). Or I have replied to
quickly? :)


On Fri, Mar 8, 2013 at 3:13 PM, Michal Sekletar <msekleta at redhat.com> wrote:

> We should not try to get information about mount unit from fragment
> if the unit was created because of /proc/self/mountinfo event.
> ---
>  src/core/mount.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/core/mount.c b/src/core/mount.c
> index 419cf27..d3333f9 100644
> --- a/src/core/mount.c
> +++ b/src/core/mount.c
> @@ -447,7 +447,11 @@ static int mount_add_default_dependencies(Mount *m) {
>          if (UNIT(m)->manager->running_as != SYSTEMD_SYSTEM)
>                  return 0;
>
> -        p = get_mount_parameters_fragment(m);
> +        if (m->from_fragment)
> +                p = get_mount_parameters_fragment(m);
> +        else
> +                p = get_mount_parameters(m);
> +
>          if (!p)
>                  return 0;
>
> --
> 1.8.1.4
>
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20130308/efd98c4b/attachment.html>