[systemd-devel] [PATCH 3/3] unit: do not start Requisite units retroactively

Michal Schmidt mschmidt at redhat.com
Tue Mar 12 17:44:14 PDT 2013


Activating Requisite units goes against the reason of existence of this
dependency type.
---
 src/core/unit.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/core/unit.c b/src/core/unit.c
index d1f109d..25109ce 100644
--- a/src/core/unit.c
+++ b/src/core/unit.c
@@ -1237,10 +1237,6 @@ static void retroactively_start_dependencies(Unit *u) {
                 if (!UNIT_IS_ACTIVE_OR_ACTIVATING(unit_active_state(other)))
                         manager_add_job(u->manager, JOB_START, other, JOB_FAIL, false, NULL, NULL);
 
-        SET_FOREACH(other, u->dependencies[UNIT_REQUISITE], i)
-                if (!UNIT_IS_ACTIVE_OR_ACTIVATING(unit_active_state(other)))
-                        manager_add_job(u->manager, JOB_START, other, JOB_REPLACE, true, NULL, NULL);
-
         SET_FOREACH(other, u->dependencies[UNIT_WANTS], i)
                 if (!UNIT_IS_ACTIVE_OR_ACTIVATING(unit_active_state(other)))
                         manager_add_job(u->manager, JOB_START, other, JOB_FAIL, false, NULL, NULL);
-- 
1.8.1.4



More information about the systemd-devel mailing list