[systemd-devel] [PATCH 1/2] smack-setup: extract rule writing into a separate function
zbyszek at in.waw.pl
Fri Mar 15 20:09:22 PDT 2013
On Fri, Mar 15, 2013 at 06:15:12PM +0000, Chen, Nathaniel wrote:
> > -----Original Message-----
> > From: Zbigniew Jędrzejewski-Szmek [mailto:zbyszek at in.waw.pl]
> > Sent: Wednesday, March 13, 2013 8:40 PM
> > To: Chen, Nathaniel
> > Cc: systemd-devel at lists.freedesktop.org; Zbigniew Jędrzejewski-Szmek
> > Subject: [PATCH 1/2] smack-setup: extract rule writing into a separate
> > function
> > Check all errors. Return the first error if looping.
> > ---
> > Hi Nathaniel,
> > your patches duplicate the same code paths (within one function!).
> > Also, if cipsco is not available, a warning would be printed, which
> > we don't want.
> > Can you check if the following two replacement patches work for you?
> > Please make sure that both a Smack kernel without configuration,
> > and a kernel with cipsco but not documentation doesn't confuse
> > systemd. I haven't checked them, I don't have Smack.
> > Zbyszek
> Tested, they both look good to go!
Pushed both now.
More information about the systemd-devel