[systemd-devel] [PATCH 2/5] udev: builtin - use RUN rather than IMPORT where it makes sense

[Tom Gundersen]

On Mon, Mar 18, 2013 at 3:01 PM, Kay Sievers <kay at vrfy.org> wrote:
> On Mon, Mar 18, 2013 at 2:17 PM, Tom Gundersen <teg at jklm.no> wrote:
>> The 'kmod' and 'firmware' builtin's do not set any variables, so no need to use
>> IMPORT. Use RUN as is already the case for the 'uaccess' builtin.
>
> IMPORT is used to be called immediately and not be queued up to the
> end of the rules handling, so that later rules could assume that this
> rule has finished. PROGRAM would do the same as IMPORT and run
> immediately, RUN always only happens at the very end, regardless where
> it shows up in the sequence.
>
> Not sure if that matter in any interesting way, but it is surely a
> different behaviour, and we should check that.

Good point. I suppose it might be possible that later rules depend on
modules/firmware being loaded, so RUN is probably the wrong choice.
Any reason the ppdev module was loaded using RUN rather than IMPORT?

I suppose this difference in execution between IMPORT/RUN/PROGRAM
should be made clearer in the man page, I'll make a stab at it unless
anyone beats me to it.

-t