[systemd-devel] [PATCH] [RFCv3] Add sync timer to journal server
alxchk at gmail.com
Mon Mar 18 22:53:45 PDT 2013
> > + if (! (f->writable && f->fd >= 0))
> > + return -1;
> -1 means EPERM. Something different is needed.
> > + fdatasync(f->fd);
> Apparently the only error code which could happen here is EIO.
> Are you sure that we want to ignore it?
I think we don't care at that point
> What is the effect of fdatasync every 10 msg during high load? Wouldn't
> this decrease the throughput significantly?
In case of high load and idle timer strategy should be the way to have
guaranted maximum count of not saved messages. But I have doubt about
it. I can set this as optional parameter with high defaults, and
introduce additional timer with maximal commit timeout. What do you
think about it?
More information about the systemd-devel