[systemd-devel] [PATCH] Don't pull in sysctl on shutdown

[Lennart Poettering]

On Wed, 13.03.13 10:27, Umut Tezduyar (umut at tezduyar.com) wrote:

> No need to try to stop systemd-sysctl on shutdown as
> this service doesn't have ExecStop= anyways.

It's kinda nice if all services are gone from the service list when we
shut down, and doing this costs pretty much nothing.

Also, the patch is incomplete, as shutdown.target is still listed in
Before=.

Anyway, I fail to see the reason why we would want to apply this patch...

> ---
>  units/systemd-sysctl.service.in |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/units/systemd-sysctl.service.in b/units/systemd-sysctl.service.in
> index 45e1ceb..d914553 100644
> --- a/units/systemd-sysctl.service.in
> +++ b/units/systemd-sysctl.service.in
> @@ -9,7 +9,6 @@
>  Description=Apply Kernel Variables
>  Documentation=man:systemd-sysctl.service(8) man:sysctl.d(5)
>  DefaultDependencies=no
> -Conflicts=shutdown.target
>  After=systemd-readahead-collect.service systemd-readahead-replay.service
>  Before=sysinit.target shutdown.target
>  ConditionPathIsReadWrite=/proc/sys/


Lennart

-- 
Lennart Poettering - Red Hat, Inc.