[systemd-devel] [PATCH] condition: add option ConditionArchitecture

[Zbigniew Jędrzejewski-Szmek]

On Wed, Mar 27, 2013 at 08:22:14AM +0100, Tollef Fog Heen wrote:
> ]] Cristian Rodríguez 
> 
> > El 26/03/13 15:17, Bill Nottingham escribió:
> > > Lukas Nykryn (lnykryn at redhat.com) said:
> > >> ---
> > >>   TODO                                  |  2 --
> > >>   man/systemd.unit.xml.in               |  8 ++++++++
> > >>   src/core/condition.c                  | 16 ++++++++++++++++
> > >>   src/core/condition.h                  |  1 +
> > >>   src/core/load-fragment-gperf.gperf.m4 |  1 +
> > >>   5 files changed, 26 insertions(+), 2 deletions(-)
> > >
> > > Not that this seems wrong, but what is the usage case for this that
> > > can't be solved via package (de)installation?
> > 
> > The patch looks fine to me, what it solves ? well.. there may be
> > generic image deployments , who contain the same packages but one of
> > them is only really useful in arch s390 or ppc.. etc..
> 
> I think it should be kernel architecture if so, since you might very
> well have multiple userland architectures enabled and working at the
> same time.  (So it should be ConditionKernelArchitecture to make it
> clear.)
Shouldn't this be a glob, like ConditionHost=?

Zbyszek