[systemd-devel] [PATCH 2/3] conf-parser: add "ignored sections" parameter

[Lennart Poettering]

On Thu, 02.05.13 02:17, Tom Gundersen (teg at jklm.no) wrote:

> On Wed, May 1, 2013 at 2:53 PM, Zbigniew Jędrzejewski-Szmek
> <zbyszek at in.waw.pl> wrote:
> > config_parse will ignore settings specified in 'ignored_sections'. The purpose
> > is being able to share a config file between two different modules (e.g. systemd
> > and systemd-sleep) without both understanding all sections. Each new section
> > has only to be added to either 'sections' or 'ignored_sections' in all modules
> > which parse the same config file.
> 
> What's the reason not to instead split the config files up into
> smaller ones? E.g. /etc/systemd/sleep.conf. If the contents is so
> different from the rest of systemd.conf that 'ignored_sections' is
> necessary, this seems like a natural choice. Am I missing something?

I think I prefer splitting this off into a new configuration file, as
Tom suggests.

(Otherwise the patch looked pretty OK. Though I even would be fine
passing this as an argument to the sleep binary and asking users to edit
unit files, since this sounds like a pretty exotic option...)

Lennart

-- 
Lennart Poettering - Red Hat, Inc.