[systemd-devel] [PATCH 2/2] hashmap.h: fix coding style issue

Lennart Poettering lennart at poettering.net
Fri May 3 07:39:35 PDT 2013


On Fri, 26.04.13 21:10, Zbigniew Jędrzejewski-Szmek (zbyszek at in.waw.pl) wrote:

> 
> On Fri, Apr 26, 2013 at 08:14:07PM +0200, Daniel Buch wrote:
> > I felt the inconsistentsy was kinda awfull.
> > 
> > I can change all to void* (instead of, void *) if you like but else leave
> > this patch to the trash?
> I think it doesn't matter too much, it can stay as is.

I think both "void *p" and "void* p" are fine, with a slight preference
for the former. "void*p" and "void * p" suck though...

The choice between "void *p" and "void* p" is up to the developers who
write the code in question I'd say. We are happy to accept patches with
either syntax, and we will not reformat them on commit.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.


More information about the systemd-devel mailing list