[systemd-devel] [PATCH 1/1] RFC: Set the Default OOM Score from configuration file

[Lennart Poettering]

On Fri, 03.05.13 16:49, Lennart Poettering (lennart at poettering.net) wrote:

> > If the unit file has 'OOMScoreAdjust' option, set the its oom_score_adj
> > as declared value as before.
> 
> I'd prefer to call this option OOMScoreAdjust= too, i.e. not with the
> "Default" prefix, and use the same nomenclature as the per-service
> option.
> 
> Generally, the entries in system.conf that are not prefixed with
> "Default" apply to PID 1 itself, while those prefixed with "Default" are
> defaults for units, and are not applied to PID 1. Since this option
> would apply to PID 1 it hence should not carry the "Default" prefix.

Hmm, actually, thinking about this a bit more, I wonder how much sense
it actually makes to alter the OOM score adjust value for PID 1. I
mean, iirc PID 1 is excluded from the OOM killer anyway, right?

Maybe this should be DefaultOOMScoreAdjust= and be explicitly copied
into each unit, the same way as we handle this for DefaultLimitCPU= →
LimitCPU=.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.