[systemd-devel] [PATCH 2/2] coredump: Handle programs with spaces in COMM

[Lennart Poettering]

On Tue, 30.04.13 13:12, Colin Walters (walters at verbum.org) wrote:

> This patch makes systemd-coredump handle processes that have
> whitespace in their COMM fields.
> 
> fs/coredump.c when given %e (as systemd-coredump uses), will end up
> joining the process arguments into a string (along with the other
> fields), then will split the entire thing up on whitespace, and use
> it as the arguments to the coredump pipe handler.
> 
> Previously, systemd-coredump would then reject them as having too many
> arguments.

I am pretty sure we should treat this as kernel bug (see other
mails). We shouldn't have to work around kernel brokeness like this from
userspace.

I now filed this:

https://bugzilla.redhat.com/show_bug.cgi?id=959479

Your patch doesn't really work correctly if you have a series of
whitespaces immediately following each others in the comm field, right?
We shouldn't try to work-around kernel brokeness if we can'd do it
properly anyway...

Lennart

-- 
Lennart Poettering - Red Hat, Inc.