[systemd-devel] build problems without largefile support

[Michael Olbrich]

Hi,

I tried to compile systemd with "--disable-largefile" and I got this:
[...]
src/shared/util.c: In function 'parse_bytes':
src/shared/util.c:2270:17: error: overflow in implicit constant conversion [-Werror=overflow]
src/shared/util.c:2271:17: error: overflow in implicit constant conversion [-Werror=overflow]
src/shared/util.c:2272:17: error: overflow in implicit constant conversion [-Werror=overflow]
src/shared/util.c: In function 'format_bytes':
src/shared/util.c:4854:17: error: overflow in implicit constant conversion [-Werror=overflow]
src/shared/util.c:4855:17: error: overflow in implicit constant conversion [-Werror=overflow]
src/shared/util.c:4856:17: error: overflow in implicit constant conversion [-Werror=overflow]
[...]

The constants for T/P/E don't fit in a 23bit off_t. That's why largefile
was introduced in the first place.
I'm not sure how to fix this. Maybe just use 'ifdef' and not support those
formats?

Regards,
Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |