[systemd-devel] [PATCH] systemd-delta: add support for drop-in snippets

Lukáš Nykrýn lnykryn at redhat.com
Thu May 16 02:11:24 PDT 2013


Dne 16.5.2013 02:41, Zbigniew Jędrzejewski-Szmek napsal(a):
> On Tue, May 14, 2013 at 05:34:28PM +0200, Lukas Nykryn wrote:
>> ---
>>   TODO                  |   3 -
>>   man/systemd-delta.xml |   7 ++
>>   src/delta/delta.c     | 182 ++++++++++++++++++++++++++++++++++++++++++++------
>>   3 files changed, 170 insertions(+), 22 deletions(-)
> Hi Lukas,
> thank you for your patience and all those patch versions.
> Nevertheless, I still have some doubts:
>
> I created the following "extended" files, one pair which
> creates and override, and the third file which is not
> overriden, but is an "extended" configuration.
>
> ==> /run/systemd/system/dracut-pre-udev.service <==
> [Unit]
> Description=dracut pre-udev hook
> Documentation=man:dracut-pre-udev.service(8)
> ...
>
> ==> /etc/systemd/system/dracut-pre-udev.service.d/0-descr.conf <==
> [Unit]
> Description=foofoo
>
> ==> /run/systemd/system/dracut-pre-udev.service.d/0-descr.conf <==
> [Unit]
> Description=foo
>
> ==> /run/systemd/system/dracut-pre-udev.service.d/0-descr2.conf <==
> [Unit]
> Documentation=foo
>
> When I run systemd-delta I see:
> ./systemd-delta --diff=0 --no-pager systemd/system -t extended
> (nothing)
>
> ./systemd-delta --diff=0 --no-pager systemd/system
> [OVERRIDDEN] /etc/systemd/system/dracut-pre-udev.service.d/0-descr.conf → /run/systemd/system/dracut-pre-udev.service.d/0-descr.conf
>
> I would expect to see 0-descr.conf and 0-descr2.conf in the first
> case... And also 0-descr2.conf in the second case... Is it actually
> supposed to behave like that? It might be nice to extend the
> description in the manpage a bit.
>
> Zbyszek
Hello,

Thanks for noticing it and your patient. There was quite stupid mistake 
and I haven't noticed it because I was testing it on unit which was 
overridden.

Lukas


More information about the systemd-devel mailing list