[systemd-devel] [PATCH 0/1] systemd will fail to compile if libgcrypt is missing

[Lennart Poettering]

On Tue, 05.11.13 15:44, Djalal Harouni (tixxdz at opendz.org) wrote:

> 
> On Mon, Nov 04, 2013 at 10:28:20PM +0100, Jan Engelhardt wrote:
> > 
> > On Monday 2013-11-04 13:01, Lennart Poettering wrote:
> > >On Sat, 02.11.13 02:11, Djalal Harouni (tixxdz at opendz.org) wrote:
> > >> 
> > >>I'm building from git tree, and I've noticed that systemd autogen.sh 
> > >>will fail if the libgcrypt and its headers are missing.
> > >
> > >This is expected that way. If you build from git you need a few 
> > >additional dependencies.[...] There's not to fix here.
> > 
> > Well, there is something of a solution—wrapping everything into 
> > m4_ifdef:
> > 
> > 	m4_ifdef([AM_PATH_LIBGCRYPT], [
> > 		AC_ARG_ENABLE([gcrypt]..................)
> > 		if test "x${have_gcrypt}" != xno; then
> > 			AM_PATH_LIBGCRYPT...............
> > 			........
> > 		fi
> > 	])
> Yes, this was proposed and rejected:
> http://lists.freedesktop.org/archives/systemd-devel/2013-May/010885.html
> 
> Lennart, the thing that confuses is that the README file states clearly
> that libgcrypt is optional, but the configure expects that the
> AM_PATH_LIBGCRYPT is defined...

The README applies to the tarball. And if you have the tarball then
libgcrypt actually *is* optional. If you build from git then a ton of
additional deps apply however (among them libgcrypt) and we will *not*
list them all in the README. This pretty much like all other projects
handle this, too.

So, yeah, such m4_ifdeffery makes no sense at all, if you are building
from git you are assumed you have a number of additional deps installed.

Lennart

-- 
Lennart Poettering, Red Hat