[systemd-devel] [PATCH 2/2] loginctl: convert to sd-bus
Lennart Poettering
lennart at poettering.net
Thu Nov 7 12:45:59 PST 2013
On Thu, 07.11.13 08:58, Simon Peeters (peeters.simon at gmail.com) wrote:
Thanks! Applied!
I made some changes though. I didn't like log_bus_error() since it took
away format strings. So I reworked that. However I did like
log_parse_error() and generalized it and added it to bus-error.h since
this is probably something like log_oom() which will be the same error
generated a thousand times everywhere.
> NOTE: the show-* subcommands do not print some properties:
> this are those with types like (so), a(so), (uo),...
> we need to fix this, but I'm not sure how
We probably should extend bus_print_all_properties to take an extra
function pointer which is called for all properties it cannot print on
its own.
Lennart
--
Lennart Poettering, Red Hat
More information about the systemd-devel
mailing list